Skip to content

fix(client-runtime): find a subagent's model by display name or alias - #9

Draft
jhomra21 wants to merge 8 commits into
mainfrom
fix/child-effort-label
Draft

jhomra21 wants to merge 8 commits into
mainfrom
fix/child-effort-label

Conversation

@jhomra21

@jhomra21 jhomra21 commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

Problem

A provider-native subagent can report its model by display name or alias, such as GPT-6 Luna, instead of the catalog slug. formatModelSelectionEffort matches only slugs, so it finds no catalog model and the subagent's status bar shows the model without its effort.

Change

formatModelSelectionEffort in threadExecution.ts still tries the exact slug first. If that fails, it matches the model's display name or an alias, ignoring case.

Scope and approval

This is a small fix for an obvious display bug, in threadExecution.ts and its test. I found no matching upstream issue (searched "subagent effort display name model alias").

Verification

  • finds the catalog model when the selection names it by display name fails on upstream main, returning null instead of Medium.
  • vp env exec --node 26.12.1 -- vp test run packages/client-runtime/src/state/threadExecution.test.ts: 12 passed.
  • Typecheck of @t3tools/client-runtime and lint on the two changed files: passed.
  • vp env exec --node 26.12.1 -- vp run check:changed: format, lint, knip, GraphQL and typecheck passed. Its tests had the same 10 upstream failures that expect Linux paths and services.
  • Not checked after the merge: an integrated pass in a real client.

These screenshots predate the upstream merge:

Before: the subagent's status bar shows the model only After: it shows the model and medium
Before: subagent status bar reads GPT-6.1 Sol, Working 41s After: subagent status bar reads GPT-6.1 Sol, medium, Working 31s

Built with Claude Opus 5.5 through Factory Droid in T3 Code. Upstream preparation by GPT-6 Luna, orchestrated by Claude Opus 5.5, through Factory Droid in T3 Code.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Oct 16, 2026
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@jhomra21
jhomra21 force-pushed the fix/child-effort-label branch from 400543a to 15ba5f2 Compare October 18, 2026 14:47
@github-actions

Copy link
Copy Markdown

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 15ba5f2.

This comment will update automatically after the next completed run.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@github-actions github-actions Bot added size:XL and removed size:M labels Oct 30, 2026
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@github-actions github-actions Bot added size:XXL and removed size:XL labels Oct 30, 2026
@jhomra21
jhomra21 marked this pull request as draft October 30, 2026 02:32
@github-actions github-actions Bot added size:S and removed size:XXL labels Oct 30, 2026
@jhomra21 jhomra21 changed the title fix(client-runtime): show native subagent effort fix(client-runtime): resolve native subagent models by name Oct 30, 2026
@jhomra21 jhomra21 changed the title fix(client-runtime): resolve native subagent models by name fix(web): show a subagent's reported effort in its hover card Oct 30, 2026
@jhomra21 jhomra21 changed the title fix(web): show a subagent's reported effort in its hover card fix(client-runtime): find a subagent's model by display name or alias Oct 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant