Repository navigation
Conversation
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
jhomra21
force-pushed
the
fix/child-effort-label
branch
from
October 18, 2026 14:47
400543a to
15ba5f2
Compare
Thread transfer impact
This comment will update automatically after the next completed run. |
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
jhomra21
marked this pull request as draft
October 30, 2026 02:32
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A provider-native subagent can report its model by display name or alias, such as
GPT-6 Luna, instead of the catalog slug.formatModelSelectionEffortmatches only slugs, so it finds no catalog model and the subagent's status bar shows the model without its effort.Change
formatModelSelectionEffortinthreadExecution.tsstill tries the exact slug first. If that fails, it matches the model's display name or an alias, ignoring case.Scope and approval
This is a small fix for an obvious display bug, in
threadExecution.tsand its test. I found no matching upstream issue (searched "subagent effort display name model alias").Verification
finds the catalog model when the selection names it by display namefails on upstream main, returningnullinstead ofMedium.vp env exec --node 26.12.1 -- vp test run packages/client-runtime/src/state/threadExecution.test.ts: 12 passed.@t3tools/client-runtimeand lint on the two changed files: passed.vp env exec --node 26.12.1 -- vp run check:changed: format, lint, knip, GraphQL and typecheck passed. Its tests had the same 10 upstream failures that expect Linux paths and services.These screenshots predate the upstream merge:
mediumBuilt with Claude Opus 5.5 through Factory Droid in T3 Code. Upstream preparation by GPT-6 Luna, orchestrated by Claude Opus 5.5, through Factory Droid in T3 Code.